| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Tue, 24 Sep 2013 10:49:37 +0100 From: Charles Keepax <ckeepax@...nsource.wolfsonmicro.com> To: Stephen Warren <swarren@...dotorg.org> Cc: lee.jones@...aro.org, sameo@...ux.intel.com, rob.herring@...xeda.com, pawel.moll@....com, mark.rutland@....com, ijc+devicetree@...lion.org.uk, rob@...dley.net, broonie@...nel.org, patches@...nsource.wolfsonmicro.com, devicetree@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH 1/5] mfd: arizona: Add device tree helper functions On Mon, Sep 23, 2013 at 03:36:36PM -0600, Stephen Warren wrote: > On 09/23/2013 12:30 PM, Charles Keepax wrote: > > - - AVDD1-supply, DBVDD1-supply, DBVDD2-supply, DBVDD3-supply, CPVDD-supply, > > + - AVDD-supply, DBVDD1-supply, DBVDD2-supply, DBVDD3-supply, CPVDD-supply, > > That looks like an incompatible change to the DT ABI. The supply name in the driver is AVDD as is the name for the pin on the datasheet, if you specify it as AVDD1 in device tree the current driver will not load. This appears to have been a copy and paste error from the wm8994 which has 2 AVDD supplies and I believe these docs were based on. I would prefer to update the documentation to match what the driver already expects rather than the other way around. Thanks, Charles -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists