linux-kernel - Re: [PATCH v2] intel-iommu: Quiesce devices before disabling IOMMU

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1380029973.21505.42.camel@i7.infradead.org>
Date:	Tue, 24 Sep 2013 14:39:33 +0100
From:	David Woodhouse <dwmw2@...radead.org>
To:	Joerg Roedel <joro@...tes.org>
Cc:	Takao Indoh <indou.takao@...fujitsu.com>,
	linux-kernel@...r.kernel.org, iommu@...ts.linux-foundation.org,
	kexec@...ts.infradead.org, alex.williamson@...hat.com,
	bhe@...hat.com
Subject: Re: [PATCH v2] intel-iommu: Quiesce devices before disabling IOMMU

On Tue, 2013-09-24 at 15:16 +0200, Joerg Roedel wrote:
> 
> I am not convinced that this is the right approach. If a device wasn't
> translated by VT-d in the old kernel doesn't mean it will not be
> translated in the new kernel. How about unconditionally resetting all
> PCI busses and/or functions here before IOMMU initialization proceeds?

Forget the IOMMU.

If a device is doing DMA in the old kernel, and *continues* doing DMA
under the new kernel, surely something ought to shut it down?

It's the generic kexec or machine_shutdown code which should be doing
this, not IOMMU code. *Especially* not Intel-specific IOMMU code. It
does not live here.

If anything, the IOMMU gives you a way to *survive* this kind of thing
and means that you might get away without quiescing devices when
otherwise you would have died.

-- 
dwmw2

Download attachment "smime.p7s" of type "application/x-pkcs7-signature" (5745 bytes)