linux-kernel - Re: [tip:x86/urgent] x86/reboot: Add quirk to make Dell C6100 use reboot=pci automatically

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5242185C.6070204@zytor.com>
Date:	Tue, 24 Sep 2013 15:55:24 -0700
From:	"H. Peter Anvin" <hpa@...or.com>
To:	mingo@...nel.org, hpa@...or.com, linux-kernel@...r.kernel.org,
	holt@....com, rmk+kernel@....linux.org.uk, stable@...r.kernel.org,
	tglx@...utronix.de, gxt@...c.pku.edu.cn, vlee@...tter.com,
	msharbiani@...tter.com
CC:	tip-bot for Masoud Sharbiani <tipbot@...or.com>,
	linux-tip-commits@...r.kernel.org
Subject: Re: [tip:x86/urgent] x86/reboot: Add quirk to make Dell C6100 use
 reboot=pci automatically

On 09/23/2013 06:37 AM, tip-bot for Masoud Sharbiani wrote:
> 
> diff --git a/arch/x86/kernel/reboot.c b/arch/x86/kernel/reboot.c
> index 563ed91..5f4ad27 100644
> --- a/arch/x86/kernel/reboot.c
> +++ b/arch/x86/kernel/reboot.c
> @@ -358,6 +358,22 @@ static struct dmi_system_id __initdata reboot_dmi_table[] = {
>  			DMI_MATCH(DMI_PRODUCT_NAME, "Precision M6600"),
>  		},
>  	},
> +	{	/* Handle problems with rebooting on the Dell PowerEdge C6100. */
> +		.callback = set_pci_reboot,
> +		.ident = "Dell PowerEdge C6100",
> +		.matches = {
> +			DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
> +			DMI_MATCH(DMI_PRODUCT_NAME, "C6100"),
> +		},
> +	},
> +	{	/* Some C6100 machines were shipped with vendor being 'Dell'. */
> +		.callback = set_pci_reboot,
> +		.ident = "Dell PowerEdge C6100",
> +		.matches = {
> +			DMI_MATCH(DMI_SYS_VENDOR, "Dell"),
> +			DMI_MATCH(DMI_PRODUCT_NAME, "C6100"),
> +		},

Aren't these substring matches anyway?  If so, the first entry is redundant.

	-hpa


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/