linux-kernel - Re: Fix style in s3c-hsotg.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20130925235329.GA25480@amd.pavel.ucw.cz>
Date:	Thu, 26 Sep 2013 01:53:30 +0200
From:	Pavel Machek <pavel@....cz>
To:	Felipe Balbi <balbi@...com>
Cc:	Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>,
	kernel list <linux-kernel@...r.kernel.org>,
	linux-usb@...r.kernel.org
Subject: Re: Fix style in s3c-hsotg.c

Hi!

> > Pavel, Felipe's remark was valid..
> > 
> > > > No, I'll not polish patch for hardware I don't have and have little
> > > > interest in.  wanted to help you, but according to your first reply,
> > > > you do not really want help.
> > > 
> > > that's your call. Now how about you stop being such a baby and go fix
> > > your mistakes to start with ? Just because I'm the maintainer of the
> > > gadget framework, doesn't mean I'm the maintainer of s3c-hsotc.c file.
> > > Maintainer != author too, btw.
> > > 
> > > Anyway, I got much better stuff to do than babysitting grown ups.
> > 
> > ..even if it could have been communicated in a gentler way.
> > 
> > Anyway s3c-hsotg.c is a driver for our hardware so I'm going to pick this
> > patch up, polish it and then re-submit it later. Thanks.
> 
> I tried a few times being nice and the response was always in the lines
> of "you should go fix the patch yourself if you don't like it" (not
> exactly these words, but same message). After some time of being nice
> and get nowhere, I just got fed up.

For the record, this is Felipe's idea of being nice:

> > > > > this is not how you send a patch, please read
> > > > > Documentation/SubmittingPatches

(What an useless reply. Yes, I know how to submit patches. I also know
that patches need to be tested, so I was not interested in "proper"
submission. I tried to explain the difference between submit patch for
inclusion and make someone look at the patch and fix the code...)

> > > > Have you considered possibility that this is how you nudge maintainer
> > > > into fix their coding style?

(Felipe)
> > > cute...
> > > 
> > > Seriously though, read that file, you're commit log has garbage in it
> > > which shouldn't go to git history.

									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/