lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 25 Sep 2013 08:49:31 +0800 From: Chen Gang <gang.chen@...anux.com> To: Tejun Heo <tj@...nel.org> CC: Andrew Morton <akpm@...ux-foundation.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, Michael Kerrisk <mtk.manpages@...il.com> Subject: Re: [PATCH] kernel/groups.c: consider about NULL for 'group_info' in all related extern functions On 09/24/2013 08:04 PM, Tejun Heo wrote: > On Tue, Sep 24, 2013 at 12:27:36PM +0800, Chen Gang wrote: >> For real world, /sbin/init will call setgroups, so user space 'help' >> kernel itself to protect this issue, but I think, we don't only depend >> on the user space help checking. >> >> The proof is below: >> >> [root@...enlinux tmp]# grep setgroups /sbin/* >> Binary file /sbin/init matches >> Binary file /sbin/rpc.statd matches >> Binary file /sbin/rsyslogd matches >> Binary file /sbin/runuser matches >> >> From reading kernel source code, kernel itself does not intend to set >> 'group_info', it is triggered by user space or another kernel mode >> sub-systems. > > Can you please demonstrate such failure? You can tell kernel to > execute a given binary instead of init with "init=" param. > OK, I will/should try, today (although I have to spend my additional time resource on it. :-( ). Hmm... in fact, in my opinion, interface (especially content system call) need make itself consistency, although at present, it can not cause issue. > Thanks. > Thanks. -- Chen Gang -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists