linux-kernel - Re: [Patch V3] drivers: power: Add support for bq24735 charger

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAKDJKT7gxWhgE3tJSq6vH-WODhy2rFbsbJQgEDSKbzudxBe5zQ@mail.gmail.com>
Date:	Wed, 25 Sep 2013 08:59:52 +0530
From:	Manish Badarkhe <badarkhe.manish@...il.com>
To:	Rhyland Klein <rklein@...dia.com>
Cc:	Anton Vorontsov <anton@...msg.org>,
	David Woodhouse <dwmw2@...radead.org>,
	Darbha Sriharsha <dsriharsha@...dia.com>,
	Stephen Warren <swarren@...dia.com>,
	Thierry Reding <thierry.reding@...il.com>,
	devicetree@...r.kernel.org,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	linux-tegra@...r.kernel.org
Subject: Re: [Patch V3] drivers: power: Add support for bq24735 charger

Hi,

> +       if (gpio_is_valid(charger->pdata->status_gpio)) {
> +               ret = devm_gpio_request(&client->dev,
> +                                       charger->pdata->status_gpio,
> +                                       name);
> +               if (ret)
> +                       dev_err(&client->dev, "Failed GPIO request: %d\n", ret);

This should include GPIO number also to show error with more verbosity.

Regards
Manish Badarkhe
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/