linux-kernel - Re: [PATCH 09/20] regulator: lp3972: use devm_regulator

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 25 Sep 2013 15:47:34 +0530
From:	Sachin Kamat <sachin.kamat@...aro.org>
To:	Jingoo Han <jg1.han@...sung.com>
Cc:	Mark Brown <broonie@...nel.org>,
	Liam Girdwood <lgirdwood@...il.com>,
	LKML <linux-kernel@...r.kernel.org>,
	Marek Szyprowski <m.szyprowski@...sung.com>
Subject: Re: [PATCH 09/20] regulator: lp3972: use devm_regulator_register()

On 25 September 2013 13:32, Jingoo Han <jg1.han@...sung.com> wrote:
> Use devm_regulator_register() to make cleanup paths simpler.

>  static int lp3972_i2c_remove(struct i2c_client *i2c)
>  {
>         struct lp3972 *lp3972 = i2c_get_clientdata(i2c);
> -       int i;
>
> -       for (i = 0; i < lp3972->num_regulators; i++)
> -               regulator_unregister(lp3972->rdev[i]);
>         kfree(lp3972->rdev);

With devm the unregister would happen after the freeing of the device.
Wouldn't this re-ordering cause any
problems?

-- 
With warm regards,
Sachin
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/