linux-kernel - Re: [PATCH] mfd: twl6040: drop devm_free_irq of devm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20130925102825.GE5132@lee--X1>
Date:	Wed, 25 Sep 2013 11:28:25 +0100
From:	Lee Jones <lee.jones@...aro.org>
To:	Sachin Kamat <sachin.kamat@...aro.org>
Cc:	Wei Yongjun <weiyj.lk@...il.com>,
	"sameo@...ux.intel.com" <sameo@...ux.intel.com>,
	yongjun_wei@...ndmicro.com.cn, LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] mfd: twl6040: drop devm_free_irq of devm_ allocated irq

On Wed, 25 Sep 2013, Sachin Kamat wrote:

> On 25 September 2013 13:07, Wei Yongjun <weiyj.lk@...il.com> wrote:
> > From: Wei Yongjun <yongjun_wei@...ndmicro.com.cn>
> >
> > -       devm_free_irq(&client->dev, twl6040->irq_ready, twl6040);
> > -       devm_free_irq(&client->dev, twl6040->irq_th, twl6040);
> >         regmap_del_irq_chip(twl6040->irq, twl6040->irq_data);
> 
> Now that the freeing of irq will happen after regmap_del_irq_chip,
> wouldn't this cause any ordering related issues?

I don't believe there is a requirement to free all associated IRQs
before deleting an irqchip.

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/