linux-kernel - Re: [PATCH tip/core/rcu 3/3] rcu: Fix occurrence of "the the" in checklist.txt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130925153321.GA6269@leaf>
Date:	Wed, 25 Sep 2013 08:33:21 -0700
From:	Josh Triplett <josh@...htriplett.org>
To:	"Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>
Cc:	linux-kernel@...r.kernel.org, mingo@...nel.org,
	laijs@...fujitsu.com, dipankar@...ibm.com,
	akpm@...ux-foundation.org, mathieu.desnoyers@...icios.com,
	niv@...ibm.com, tglx@...utronix.de, peterz@...radead.org,
	rostedt@...dmis.org, dhowells@...hat.com, edumazet@...gle.com,
	darren@...art.com, fweisbec@...il.com, sbw@....edu,
	Michael Opdenacker <michael.opdenacker@...e-electrons.com>
Subject: Re: [PATCH tip/core/rcu 3/3] rcu: Fix occurrence of "the the" in
 checklist.txt

On Wed, Sep 25, 2013 at 06:55:27AM -0700, Paul E. McKenney wrote:
> On Tue, Sep 24, 2013 at 08:47:39PM -0700, Josh Triplett wrote:
> > On Tue, Sep 24, 2013 at 06:17:23PM -0700, Paul E. McKenney wrote:
> > > From: Michael Opdenacker <michael.opdenacker@...e-electrons.com>
> > > 
> > > Signed-off-by: Michael Opdenacker <michael.opdenacker@...e-electrons.com>
> > > Signed-off-by: Paul E. McKenney <paulmck@...ux.vnet.ibm.com>
> > > ---
> > 
> > See comment below.
> > 
> > >  Documentation/RCU/checklist.txt | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > 
> > > diff --git a/Documentation/RCU/checklist.txt b/Documentation/RCU/checklist.txt
> > > index 7703ec7..ad6cba4 100644
> > > --- a/Documentation/RCU/checklist.txt
> > > +++ b/Documentation/RCU/checklist.txt
> > > @@ -203,7 +203,7 @@ over a rather long period of time, but improvements are always welcome!
> > >  	the corresponding readers must disable preemption, possibly
> > >  	by calling rcu_read_lock_sched() and rcu_read_unlock_sched().
> > >  	If the updater uses synchronize_srcu() or call_srcu(),
> > > -	the the corresponding readers must use srcu_read_lock() and
> > > +	the corresponding readers must use srcu_read_lock() and
> > 
> > I think this may have actually been a typo for "then", as in "If the
> > updater uses ..., then the corresponding readers must use ...".
> 
> Good point -- that would make the sentence construction parallel with
> the surrounding sentences.  Updated patch below.
> 
> 							Thanx, Paul
> 
> rcu: Fix occurrence of "the the" in checklist.txt
> 
> Signed-off-by: Michael Opdenacker <michael.opdenacker@...e-electrons.com>
> Signed-off-by: Paul E. McKenney <paulmck@...ux.vnet.ibm.com>
> [ paulmck: Add "then" as suggested by Josh Triplett. ]

Reviewed-by: Josh Triplett <josh@...htriplett.org>

> diff --git a/Documentation/RCU/checklist.txt b/Documentation/RCU/checklist.txt
> index 7703ec7..9126619 100644
> --- a/Documentation/RCU/checklist.txt
> +++ b/Documentation/RCU/checklist.txt
> @@ -202,8 +202,8 @@ over a rather long period of time, but improvements are always welcome!
>  	updater uses call_rcu_sched() or synchronize_sched(), then
>  	the corresponding readers must disable preemption, possibly
>  	by calling rcu_read_lock_sched() and rcu_read_unlock_sched().
> -	If the updater uses synchronize_srcu() or call_srcu(),
> -	the the corresponding readers must use srcu_read_lock() and
> +	If the updater uses synchronize_srcu() or call_srcu(), then
> +	the corresponding readers must use srcu_read_lock() and
>  	srcu_read_unlock(), and with the same srcu_struct.  The rules for
>  	the expedited primitives are the same as for their non-expedited
>  	counterparts.  Mixing things up will result in confusion and
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/