linux-kernel - Re: [PATCH] checkpatch: Find CamelCase definitions of struct/union/enum

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1380123344.17366.5.camel@joe-AO722>
Date:	Wed, 25 Sep 2013 08:35:44 -0700
From:	Joe Perches <joe@...ches.com>
To:	Al Viro <viro@...IV.linux.org.uk>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	Andy Whitcroft <apw@...dowen.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] checkpatch: Find CamelCase definitions of
 struct/union/enum

On Wed, 2013-09-25 at 16:24 +0100, Al Viro wrote:
> On Tue, Sep 24, 2013 at 11:38:54AM -0700, Joe Perches wrote:
> > Checkpatch doesn't currently find CamelCase definitions
> > of structs, unions or enums.
> > 
> > Add that ability.
> 
> Fix your regex.  As it is, it catches the things that are not camelcase
> by any stretch of definition - [A-Z][a-z]+ will get caught by that and
> it's neither camelcase nor something that ought to be discouraged for
> e.g. enum member names.
> 
> CamelCase refers to caps in the middle of a compound, used to visually
> separate them.

We disagree.

I think Propercase should be discouraged.
ie: Qdisc et al.

Anyway, this finds things like Qdisc in
headers and adds them to the "ignore" list.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/