linux-kernel - Re: [pchecks v2 2/2] percpu: Add preemption checks to __this

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0000014155fdd6cf-d54da8b8-2198-40ce-8831-4559971e69f0-000000@email.amazonses.com>
Date:	Wed, 25 Sep 2013 16:40:07 +0000
From:	Christoph Lameter <cl@...ux.com>
To:	Ingo Molnar <mingo@...nel.org>
cc:	Tejun Heo <tj@...nel.org>, akpm@...uxfoundation.org,
	linux-arch@...r.kernel.org, Steven Rostedt <srostedt@...hat.com>,
	linux-kernel@...r.kernel.org, Peter Zijlstra <peterz@...radead.org>
Subject: Re: [pchecks v2 2/2] percpu: Add preemption checks to __this_cpu
 ops

On Tue, 24 Sep 2013, Ingo Molnar wrote:

> Ok, this variant looks pretty good, modulo testing. I'd do:
>
>   s/check_preemption/check_preemption_disabled
>
> but that's a minor detail.

Sure.

> > +config DEBUG_THIS_CPU_OPERATIONS
> > +	bool "Debug __this_cpu operations"
> > +	depends on DEBUG_PREEMPT
> > +	default n
> > +	help
> > +	  Enables preemption checks for __this_cpu macros. These
> > +	  are macros to generate single instruction operations on
> > +	  per cpu data. The option only affects the __this_cpu variant
> > +	  which is used when fallback to multiple instructions without
> > +	  other synchronization is possible. A verification is then
> > +	  done to make sure that the thread cannot be preempted.
>
> I don't think there's a need to make this a separate preemption debug
> option: smp_processor_id() is really just a subset of the checks.

I think this is necessary since it seems that the discussions on how to do
the raw_cpu conversions may take some time. If we enable it by default
then there will be numerous new log messages. That way a developer can
enable it for working on this.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/