linux-kernel - Re: [PATCHv2] tracing/events: Add bounce tracing to swiotbl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130925142640.6c2f1ee0@gandalf.local.home>
Date:	Wed, 25 Sep 2013 14:26:40 -0400
From:	Steven Rostedt <rostedt@...dmis.org>
To:	Konrad Rzeszutek Wilk <konrad.wilk@...cle.com>
Cc:	Zoltan Kiss <zoltan.kiss@...rix.com>,
	Jeremy Fitzhardinge <jeremy@...p.org>,
	Frederic Weisbecker <fweisbec@...il.com>,
	Ingo Molnar <mingo@...hat.com>, linux-kernel@...r.kernel.org,
	xen-devel@...ts.xensource.com,
	virtualization@...ts.linux-foundation.org
Subject: Re: [PATCHv2] tracing/events: Add bounce tracing to swiotbl

On Wed, 25 Sep 2013 13:56:49 -0400
Konrad Rzeszutek Wilk <konrad.wilk@...cle.com> wrote:

> .. snip..
> > >+	TP_printk("dev_name: %s dma_mask=%llx dev_addr=%llx "
> > >+		"size=%zu swiotlb_force=%x",
> > >+		__get_str(dev_name),
> > >+		__entry->dma_mask,
> > >+		(unsigned long long)__entry->dev_addr,
> > >+		__entry->size,
> > >+		__entry->swiotlb_force)
> 
> Would it make sense to do something like this:
> 
> 		__entry->swiotlb_force ? "swiotlb_force" : "")

I think that's fine. I do believe that the libtraceevents can parse the
"?:" syntax.

-- Steve
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/