linux-kernel - Re: [tip:x86/urgent] x86/smpboot: Fix announce_cpu() to printk() the last "OK" properly

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 25 Sep 2013 20:29:36 +0200
From:	Ingo Molnar <mingo@...nel.org>
To:	Borislav Petkov <bp@...en8.de>
Cc:	hpa@...or.com, linux-kernel@...r.kernel.org,
	huawei.libin@...wei.com, wangyijing@...wei.com,
	fenghua.yu@...el.com, tglx@...utronix.de, guohanjun@...wei.com,
	paul.gortmaker@...driver.com, linux-tip-commits@...r.kernel.org
Subject: Re: [tip:x86/urgent] x86/smpboot: Fix announce_cpu() to printk() the
 last "OK" properly


* Borislav Petkov <bp@...en8.de> wrote:

> On Thu, Sep 05, 2013 at 10:52:15AM -0700, tip-bot for Libin wrote:
> > Commit-ID:  52239484bf8aec031afa84ae08aa88224d819b93
> > Gitweb:     http://git.kernel.org/tip/52239484bf8aec031afa84ae08aa88224d819b93
> > Author:     Libin <huawei.libin@...wei.com>
> > AuthorDate: Thu, 5 Sep 2013 18:57:56 +0800
> > Committer:  Ingo Molnar <mingo@...nel.org>
> > CommitDate: Thu, 5 Sep 2013 15:05:37 +0200
> > 
> > x86/smpboot: Fix announce_cpu() to printk() the last "OK" properly
> > 
> > When booting secondary CPUs, announce_cpu() is called to show which cpu has
> > been brought up. For example:
> > 
> > [    0.402751] smpboot: Booting Node   0, Processors  #1 #2 #3 #4 #5 OK
> > [    0.525667] smpboot: Booting Node   1, Processors  #6 #7 #8 #9 #10 #11 OK
> > [    0.755592] smpboot: Booting Node   0, Processors  #12 #13 #14 #15 #16 #17 OK
> > [    0.890495] smpboot: Booting Node   1, Processors  #18 #19 #20 #21 #22 #23
> > 
> > But the last "OK" is lost, because 'nr_cpu_ids-1' represents the maximum
> > possible cpu id. It should use the maximum present cpu id in case not all
> > CPUs booted up.
> > 
> > Signed-off-by: Libin <huawei.libin@...wei.com>
> > Cc: <guohanjun@...wei.com>
> > Cc: <wangyijing@...wei.com>
> > Cc: <fenghua.yu@...el.com>
> > Cc: <paul.gortmaker@...driver.com>
> > Link: http://lkml.kernel.org/r/1378378676-18276-1-git-send-email-huawei.libin@huawei.com
> > [ tweaked the changelog, removed unnecessary line break, tweaked the format to align the fields vertically. ]
> > Signed-off-by: Ingo Molnar <mingo@...nel.org>
> 
> Hmm, this one kinda funnied up output on smaller boxes:
> 
> [    0.089340] smpboot: Booting Node   0, Processors  #   1
> [    0.105930] SMP alternatives: lockdep: fixing up alternatives
> [    0.106073]  #   2
> [    0.122237] SMP alternatives: lockdep: fixing up alternatives
> [    0.122384]  #   3 OK
> [    0.136464] Brought up 4 CPUs
> [    0.136539] smpboot: Total of 4 processors activated (23146.40 BogoMIPS)

Indeed, that should be fixed.

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/