linux-kernel - Re: [RFC PATCH] mfd: arizona: Update device tree regulator bindings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130925183201.GT3226@sirena.org.uk>
Date:	Wed, 25 Sep 2013 19:32:01 +0100
From:	Mark Brown <broonie@...nel.org>
To:	Charles Keepax <ckeepax@...nsource.wolfsonmicro.com>
Cc:	devicetree@...r.kernel.org, patches@...nsource.wolfsonmicro.com,
	linux-kernel@...r.kernel.org
Subject: Re: [RFC PATCH] mfd: arizona: Update device tree regulator bindings

On Wed, Sep 25, 2013 at 06:47:52PM +0100, Charles Keepax wrote:

> This patch creates a sub-node for the codec and attaches the required
> regulators here using the of_compatible field on the mfd_cell.

> Another issue with the Arizona bindings, I am not sure
> exactly what the best approach is this patch seems like the
> "correct" fix, but it does require a change to the binding,
> although the current binding is non-functional.

No, this is not sensible - what you're doing here is clearly a Linux
implementation detail.  

> Alternatively I could simply set the codec of_node to match
> the mfd one manually in the codec driver which wouldn't need
> the binding changing but feels a bit like a work around.

That's not clever either, fiddling around with the data structures like
that is bound to cause referencing problems ("I just freed the device,
let's clean up all the memory") and general fragility.

> Any thoughts would be greatly appreciated?

You need to do something like arrange for the regulator API to resolve
attempts to look up regulators on the subnode using the parent, the
device is virtual after all.

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)