linux-kernel - Re: [PATCH] tile: include: asm: use 'long long' instead of 'u64' for atomic64

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <524338F6.2090508@tilera.com>
Date:	Wed, 25 Sep 2013 15:26:46 -0400
From:	Chris Metcalf <cmetcalf@...era.com>
To:	Chen Gang <gang.chen@...anux.com>
CC:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] tile: include: asm: use 'long long' instead of 'u64'
 for atomic64_t and its related functions

On 9/25/2013 12:14 AM, Chen Gang wrote:
> atomic* value is signed value, and atomic* functions need also process
> signed value (parameter value, and return value), so use 'long long'
> instead of 'u64'.
>
> After replacement, it will also fix a bug for atomic64_add_negative():
> "u64 is never less than 0".
>
> The modifications are:
>
>   in vim, use "1,% s/\<u64\>/long long/g" command.
>   remove redundant '__aligned(8)' and a type case '(u64 *)'.
>   be sure of 80 (and macro '\') columns limitation after replacement.
>
>
> Signed-off-by: Chen Gang <gang.chen@...anux.com>
> ---
>  arch/tile/include/asm/atomic.h    |    5 +++--
>  arch/tile/include/asm/atomic_32.h |   27 +++++++++++++++------------
>  arch/tile/include/asm/cmpxchg.h   |   28 +++++++++++++++++-----------
>  arch/tile/lib/atomic_32.c         |    8 ++++----
>  4 files changed, 39 insertions(+), 29 deletions(-)

Thanks!  Taken into the tile tree for 3.12.

-- 
Chris Metcalf, Tilera Corp.
http://www.tilera.com

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/