linux-kernel - Re: [PATCH] checkpatch: Find CamelCase definitions of struct/union/enum

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 25 Sep 2013 12:48:35 -0700
From:	Joe Perches <joe@...ches.com>
To:	Theodore Ts'o <tytso@....edu>
Cc:	Al Viro <viro@...IV.linux.org.uk>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Andy Whitcroft <apw@...dowen.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] checkpatch: Find CamelCase definitions of
 struct/union/enum

On Wed, 2013-09-25 at 15:30 -0400, Theodore Ts'o wrote:
> On Wed, Sep 25, 2013 at 12:22:00PM -0700, Joe Perches wrote:
> > 
> > > 	* labels a-la Enomem, etc.  I've been using those and I will
> > > keep doing so, checkpatch.pl and its users be damned.
> > 
> > Good on you.
> 
> I'm with Al.  This is just silly to add to checkpatch.
> 
> > Fine by me.  Don't use checkpatch.  No stress from me.
> 
> I still get some of your minions sending patches asking to "fix" ext4
> from time to time.  It wastes everyone's time.

ext4 still has several code style nits that could be
improved.  Up to you to do anything about them though.

no space after comma, pointer spaces, and split strings
are nits.

> BTW, checkpatch barfs on pretty much everything in
> linux/trace/events/*.h

include/trace/events/*.h

As I've said multiple times, checkpatch is a stupid
little tool that can be ignored by anyone with
different tastes.

And, shrug.  I think straining for alignment like below
doesn't really add much.

$ ./scripts/checkpatch.pl -f include/trace/events/jbd.h
ERROR: space prohibited after that open parenthesis '('
#17: FILE: trace/events/jbd.h:17:
+		__field(	dev_t,	dev			)

ERROR: space prohibited before that close parenthesis ')'
#17: FILE: trace/events/jbd.h:17:
+		__field(	dev_t,	dev			)

ERROR: space prohibited after that open parenthesis '('
#18: FILE: trace/events/jbd.h:18:
+		__field(	int,	result			)



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/