linux-kernel - Re: [PATCH usb 1/2] usb: musb: Add missing ATOMIC_INIT_NOTIFIER

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130925203333.GU10746@radagast>
Date:	Wed, 25 Sep 2013 15:33:33 -0500
From:	Felipe Balbi <balbi@...com>
To:	Pali Rohár <pali.rohar@...il.com>
CC:	<balbi@...com>,
	Javier Martinez Canillas <martinez.javier@...il.com>,
	Pavel Machek <pavel@....cz>, Tony Lindgren <tony@...mide.com>,
	Anton Vorontsov <anton@...msg.org>,
	Russell King <linux@....linux.org.uk>,
	David Woodhouse <dwmw2@...radead.org>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	<freemangordon@....bg>, Aaro Koskinen <aaro.koskinen@....fi>,
	"linux-omap@...r.kernel.org" <linux-omap@...r.kernel.org>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	Linux Kernel <linux-kernel@...r.kernel.org>,
	<linux-usb@...r.kernel.org>
Subject: Re: [PATCH usb 1/2] usb: musb: Add missing ATOMIC_INIT_NOTIFIER_HEAD

Hi,

On Wed, Sep 25, 2013 at 10:17:38AM +0200, Pali Rohár wrote:
> On Wednesday 18 September 2013 19:03:33 Pali Rohár wrote:
> > &twl->phy.notifier is not initalized
> > 
> > Signed-off-by: Pali Rohár <pali.rohar@...il.com>
> > 
> > diff --git a/drivers/usb/phy/phy-twl4030-usb.c
> > b/drivers/usb/phy/phy-twl4030-usb.c index 8f78d2d..efe6155
> > 100644
> > --- a/drivers/usb/phy/phy-twl4030-usb.c
> > +++ b/drivers/usb/phy/phy-twl4030-usb.c
> > @@ -705,6 +705,8 @@ static int twl4030_usb_probe(struct
> > platform_device *pdev) if (device_create_file(&pdev->dev,
> > &dev_attr_vbus)) dev_warn(&pdev->dev, "could not create sysfs
> > file\n");
> > 
> > +	ATOMIC_INIT_NOTIFIER_HEAD(&twl->phy.notifier);
> > +
> >  	/* Our job is to use irqs and status from the power module
> >  	 * to keep the transceiver disabled when nothing's
> > connected. *
> 
> I sent above patch week ago. Did you already included it?

look at my testing branch.

-- 
balbi

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)