linux-kernel - Re: [PATCH 13/21] cpuidle: use drv instead of cpuidle_driver in show_current

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <52435E1A.9010108@linaro.org>
Date:	Thu, 26 Sep 2013 00:05:14 +0200
From:	Daniel Lezcano <daniel.lezcano@...aro.org>
To:	Viresh Kumar <viresh.kumar@...aro.org>, rjw@...k.pl
CC:	linaro-kernel@...ts.linaro.org, patches@...aro.org,
	linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 13/21] cpuidle: use drv instead of cpuidle_driver in show_current_driver()

On 09/22/2013 03:21 AM, Viresh Kumar wrote:
> Instances of "struct cpuidle_driver *" are consistently named as "drv" in
> cpuidle core. Its broken only at one place: show_current_driver().
> 
> Fix it for consistency.
> 
> Signed-off-by: Viresh Kumar <viresh.kumar@...aro.org>

Acked-by: Daniel Lezcano <daniel.lezcano@...aro.org>

> ---
>  drivers/cpuidle/sysfs.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/cpuidle/sysfs.c b/drivers/cpuidle/sysfs.c
> index a022393..e918b6d 100644
> --- a/drivers/cpuidle/sysfs.c
> +++ b/drivers/cpuidle/sysfs.c
> @@ -52,12 +52,12 @@ static ssize_t show_current_driver(struct device *dev,
>  				   char *buf)
>  {
>  	ssize_t ret;
> -	struct cpuidle_driver *cpuidle_driver;
> +	struct cpuidle_driver *drv;
>  
>  	spin_lock(&cpuidle_driver_lock);
> -	cpuidle_driver = cpuidle_get_driver();
> -	if (cpuidle_driver)
> -		ret = sprintf(buf, "%s\n", cpuidle_driver->name);
> +	drv = cpuidle_get_driver();
> +	if (drv)
> +		ret = sprintf(buf, "%s\n", drv->name);
>  	else
>  		ret = sprintf(buf, "none\n");
>  	spin_unlock(&cpuidle_driver_lock);
> 


-- 
 <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/