linux-kernel - Re: [PATCH] staging: dgrp: Convert to use device_create_with

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20130925230616.GA5530@roeck-us.net>
Date:	Wed, 25 Sep 2013 16:06:16 -0700
From:	Guenter Roeck <linux@...ck-us.net>
To:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org,
	Bill Pemberton <wfp5p@...ginia.edu>
Subject: Re: [PATCH] staging: dgrp: Convert to use device_create_with_groups

On Wed, Sep 25, 2013 at 04:02:44PM -0700, Greg Kroah-Hartman wrote:
> On Sat, Aug 31, 2013 at 03:56:06PM -0700, Guenter Roeck wrote:
> > Use device_create_with_groups to create sysfs attributes together with device.
> > Also create class attribute together with class registration.
> > This simplifies the code and ensures that attribute files exist when udev
> > events are generated.
> > 
> > Signed-off-by: Guenter Roeck <linux@...ck-us.net>
> > ---
> > I suspect that the 'register_with_sysfs' attribute exists to work around
> > the problem solved with this patch. It doesn't make much sense otherwise.
> > Can it be removed ?
> 
> All of these sysfs files can be removed, they shouldn't be there, as it
> looks like they are used for odd configuration things.
> 
> And a single tty driver shouldn't be a "class" at all.
> 
> sorry,
> 
No need to be sorry - not my driver, nor am I using it ;).
I am perfectly fine with you dropping this patch.

Guenter
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/