linux-kernel - Re: [PATCH V3 12/14] regulator: tps6524x: use devm_regulator

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 26 Sep 2013 16:22:50 +0800
From:	Axel Lin <axel.lin@...ics.com>
To:	Jingoo Han <jg1.han@...sung.com>
Cc:	Mark Brown <broonie@...nel.org>,
	Liam Girdwood <lgirdwood@...il.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Sachin Kamat <sachin.kamat@...aro.org>
Subject: Re: [PATCH V3 12/14] regulator: tps6524x: use devm_regulator_register()

> Hi Axel,
>
> I really appreciate your comment.
>
> Then, you mean the following.
> If I am wrong, please let me know. :-)
> Thank you.

Then you can remove pmic_remove() function,like below diff.
With these change, you can add Reviewed-by: Axel Lin <axel.lin@...ics.com>

diff --git a/drivers/regulator/tps6524x-regulator.c
b/drivers/regulator/tps6524x-regulator.c
index 8b9ee39..0c0590d 100644
--- a/drivers/regulator/tps6524x-regulator.c
+++ b/drivers/regulator/tps6524x-regulator.c
@@ -577,20 +577,6 @@ static struct regulator_ops regulator_ops = {
  .get_current_limit = get_current_limit,
 };

-static int pmic_remove(struct spi_device *spi)
-{
- struct tps6524x *hw = spi_get_drvdata(spi);
- int i;
-
- if (!hw)
- return 0;
- for (i = 0; i < N_REGULATORS; i++) {
- regulator_unregister(hw->rdev[i]);
- hw->rdev[i] = NULL;
- }
- return 0;
-}
-
 static int pmic_probe(struct spi_device *spi)
 {
  struct tps6524x *hw;
@@ -598,7 +584,7 @@ static int pmic_probe(struct spi_device *spi)
  const struct supply_info *info = supply_info;
  struct regulator_init_data *init_data;
  struct regulator_config config = { };
- int ret = 0, i;
+ int i;

  init_data = dev_get_platdata(dev);
  if (!init_data) {
@@ -631,24 +617,17 @@ static int pmic_probe(struct spi_device *spi)
  config.init_data = init_data;
  config.driver_data = hw;

- hw->rdev[i] = regulator_register(&hw->desc[i], &config);
- if (IS_ERR(hw->rdev[i])) {
- ret = PTR_ERR(hw->rdev[i]);
- hw->rdev[i] = NULL;
- goto fail;
- }
+ hw->rdev[i] = devm_regulator_register(dev, &hw->desc[i],
+      &config);
+ if (IS_ERR(hw->rdev[i]))
+ return PTR_ERR(hw->rdev[i]);
  }

  return 0;
-
-fail:
- pmic_remove(spi);
- return ret;
 }

 static struct spi_driver pmic_driver = {
  .probe = pmic_probe,
- .remove = pmic_remove,
  .driver = {
  .name = "tps6524x",
  .owner = THIS_MODULE,
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/