linux-kernel - Re: [PATCH 1/1] i2c-ismt: add Initialize DMA buffer code ismt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130926084032.GB3057@katana>
Date:	Thu, 26 Sep 2013 10:40:32 +0200
From:	Wolfram Sang <wsa@...-dreams.de>
To:	James Ralston <james.d.ralston@...el.com>
Cc:	Neil Horman <nhorman@...driver.com>,
	Seth Heasley <seth.heasley@...el.com>,
	linux-i2c@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/1] i2c-ismt: add Initialize DMA buffer code
 ismt_access()

On Tue, Sep 24, 2013 at 04:47:55PM -0700, James Ralston wrote:
> This patch adds code to Initialize the DMA buffer to compensate for possible hardware data corruption.

Take care of the line width here.

> Signed-off-by: James Ralston <james.d.ralston@...el.com>
> ---
>  drivers/i2c/busses/i2c-ismt.c |    3 +++
>  1 files changed, 3 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/i2c/busses/i2c-ismt.c b/drivers/i2c/busses/i2c-ismt.c
> index 8ed79a0..d3f30ea 100644
> --- a/drivers/i2c/busses/i2c-ismt.c
> +++ b/drivers/i2c/busses/i2c-ismt.c
> @@ -393,6 +393,9 @@ static int ismt_access(struct i2c_adapter *adap, u16 addr,
>  
>  	desc = &priv->hw[priv->head];
>  
> +	/* Initialize the DMA buffer */
> +	memset(priv->dma_buffer, 0, (I2C_SMBUS_BLOCK_MAX+1));

sizeof()?

> +
>  	/* Initialize the descriptor */
>  	memset(desc, 0, sizeof(struct ismt_desc));
>  	desc->tgtaddr_rw = ISMT_DESC_ADDR_RW(addr, read_write);
> -- 
> 1.7.7.6
> 

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)