linux-kernel - Re: [PATCH v2] mei: me: downgrade two errors to debug level

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+i0qc4UZmJ21wCHVERnLAFjO_JgqoQpaMNhRMsnjEKVC9VpVw@mail.gmail.com>
Date:	Thu, 26 Sep 2013 11:56:40 +0300
From:	Tomas Winkler <tomasw@...il.com>
To:	Paul Bolle <pebolle@...cali.nl>
Cc:	Adam Jackson <ajax@...hat.com>, Joe Perches <joe@...ches.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] mei: me: downgrade two errors to debug level

On Thu, Sep 19, 2013 at 1:17 PM, Paul Bolle <pebolle@...cali.nl> wrote:
> The mei_me driver prints "suspend" at error level at each suspend. It
> also prints "stop" at error level at driver unload. Downgrade these
> uninteresting messages to debug level.
>
> Signed-off-by: Paul Bolle <pebolle@...cali.nl>
> ---
> 0) v1 was called "mei: me: downgrade "suspend" message to debug level".
> v2 also downgrades the "stop" message.
>
> 1) Added Adam and Joe to Cc:. They were involved in discussing a patch
> by Adam, which was similar to my v1, about a week ago.
>
> 2) Still lightly tested only, but now on top of v3.11.1.
>
>  drivers/misc/mei/pci-me.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/misc/mei/pci-me.c b/drivers/misc/mei/pci-me.c
> index 1b3844e..897ee6b 100644
> --- a/drivers/misc/mei/pci-me.c
> +++ b/drivers/misc/mei/pci-me.c
> @@ -231,7 +231,7 @@ static void mei_me_remove(struct pci_dev *pdev)
>         hw = to_me_hw(dev);
>
>
> -       dev_err(&pdev->dev, "stop\n");
> +       dev_dbg(&pdev->dev, "stop\n");
>         mei_stop(dev);
>
>         /* disable interrupts */
> @@ -262,7 +262,7 @@ static int mei_me_pci_suspend(struct device *device)
>         if (!dev)
>                 return -ENODEV;
>
> -       dev_err(&pdev->dev, "suspend\n");
> +       dev_dbg(&pdev->dev, "suspend\n");
>
>         mei_stop(dev);
>
> --
> 1.8.1.4

Ack
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/