linux-kernel - Re: [PATCH V2 05/18] regulator: fixed: use devm_regulator

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20130926101605.GC19304@sirena.org.uk>
Date:	Thu, 26 Sep 2013 11:16:05 +0100
From:	Mark Brown <broonie@...nel.org>
To:	Jingoo Han <jg1.han@...sung.com>
Cc:	'Sachin Kamat' <sachin.kamat@...aro.org>,
	'Liam Girdwood' <lgirdwood@...il.com>,
	'LKML' <linux-kernel@...r.kernel.org>,
	'Steve Twiss' <stwiss.opensource@...semi.com>,
	'David Dajun Chen' <david.chen@...semi.com>
Subject: Re: [PATCH V2 05/18] regulator: fixed: use devm_regulator_register()

On Thu, Sep 26, 2013 at 03:25:59PM +0900, Jingoo Han wrote:
> On Thursday, September 26, 2013 3:14 PM, Sachin Kamat wrote:

> > > -       regulator_unregister(drvdata->dev);
> > >         kfree(drvdata->desc.supply_name);
> > >         kfree(drvdata->desc.name);

> > Sorry, couldn't go through all your patches yesterday.
> > This one looks a bit scary too as some of the driver data is already
> > freed before unregistering.

> I looked at regulator_unregister(). I am not sure that this is safe.
> So, I will remove this patch from next v3 patch series.
> Thank you for your comment. :-)

Yes, it'd be better to convert the allocations to be managed ones first.

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)