linux-kernel - Re: [PATCH 02/20] regulator: ab8500: use devm_regulator

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-id: <000301ceba57$4ef39370$ecdaba50$%han@samsung.com>
Date:	Thu, 26 Sep 2013 10:25:38 +0900
From:	Jingoo Han <jg1.han@...sung.com>
To:	'Sachin Kamat' <sachin.kamat@...aro.org>
Cc:	'Mark Brown' <broonie@...nel.org>,
	'Liam Girdwood' <lgirdwood@...il.com>,
	'LKML' <linux-kernel@...r.kernel.org>,
	'Bengt Jonsson' <bengt.g.jonsson@...ricsson.com>,
	'Jingoo Han' <jg1.han@...sung.com>
Subject: Re: [PATCH 02/20] regulator: ab8500: use devm_regulator_register()

On Wednesday, September 25, 2013 7:21 PM, Sachin Kamat wrote:
> On 25 September 2013 13:21, Jingoo Han <jg1.han@...sung.com> wrote:
> > Use devm_regulator_register() to make cleanup paths simpler.
> 
> > -       for (i = 0; i < abx500_regulator.info_size; i++) {
> > -               struct ab8500_regulator_info *info = NULL;
> > -               info = &abx500_regulator.info[i];
> > -
> > -               dev_vdbg(rdev_get_dev(info->regulator),
> > -                       "%s-remove\n", info->desc.name);
> > -
> > -               regulator_unregister(info->regulator);
> > -       }
> > +       int err;
> >
> >         /* remove regulator debug */
> >         err = ab8500_regulator_debug_exit(pdev);
> 
> Wouldn't re-ordering (unregistering after ab8500_regulator_debug_exit)
> cause any problems here ?
> 

OK, I see. 
There is no ab8500_regulator_debug_exit() in the current kernel.
However, in my opinion, ab8500_regulator_debug_exit() should be
called, after regulator_unregister() is called.

I will remove this patch from next V2 patch series.
Thank you.

Bengt Jonsson,
If I am wrong, please let me know kindly. :-)

Best regards,
Jingoo Han

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/