linux-kernel - Re: [PATCH] perf: fix infinite loop with corrupted header

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130926140613.GB26159@ghostprotocols.net>
Date:	Thu, 26 Sep 2013 11:06:13 -0300
From:	Arnaldo Carvalho de Melo <acme@...stprotocols.net>
To:	Namhyung Kim <namhyung@...nel.org>
Cc:	David Ahern <dsahern@...il.com>, Sonny Rao <sonnyrao@...omium.org>,
	linux-kernel@...r.kernel.org,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Ingo Molnar <mingo@...hat.com>, Jiri Olsa <jolsa@...hat.com>,
	Stephane Eranian <eranian@...gle.com>
Subject: Re: [PATCH] perf: fix infinite loop with corrupted header

Em Thu, Sep 26, 2013 at 10:59:37PM +0900, Namhyung Kim escreveu:
> 2013-09-26 (목), 10:46 -0300, Arnaldo Carvalho de Melo:
> > Em Thu, Sep 26, 2013 at 07:34:56AM -0600, David Ahern escreveu:
> > > On 9/25/13 11:20 PM, Sonny Rao wrote:
> > > >We recently ran into a corrupt perf data file which mostly looked okay
> > > >but the section size for data was set to 0.  This caused perf report to
> > > >get into an infinite loop in __perf_session_process_events().  Let's
> > > >just avoid this by bailing early and reporting it if there's an
> > > >invalid header.
> > > 
> > > Been suggested before:
> > > https://lkml.org/lkml/2013/5/9/405
> > 
> > Thanks for the pointer (and this latest patch as well), looking at it
> > now.
> > 
> > - Arnaldo
> >  
> > > Other changes went in around that time as well. Are you still seeing
> > > the loop on latest source?
> 
> Did you mean this?

Not at that moment, but yes, I looked up the discussion and found this,
which I think is sensible, would like just to do some testing, and if
you could submit a patch combining your change with David's, I think it
would be good.

Thanks,

- Arnaldo
 
> https://lkml.org/lkml/2013/5/9/670
> 
> 
> Thanks,
> Namhyung
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/