lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 26 Sep 2013 16:11:14 +0200 From: Veaceslav Falico <vfalico@...hat.com> To: linux-pci@...r.kernel.org Cc: Veaceslav Falico <vfalico@...hat.com>, Bjorn Helgaas <bhelgaas@...gle.com>, Neil Horman <nhorman@...driver.com>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, linux-kernel@...r.kernel.org Subject: [PATCH v2 2/3] msi: always unregister ->msi_kset within free_msi_irqs() Currently we create and populate ->msi_kset while allocating irqs in populate_msi_sysfs(), however if it fails and/or we want to free the entries - we don't always remove it, and we might have problems if we've failed to allocate irqs and try it again. To fix that, move the unregister part to free_msi_irqs() and remove already existing ones. Also, verify if it was actually created - we don't always call free_msi_irqs() after populate_msi_sysfs(). CC: Bjorn Helgaas <bhelgaas@...gle.com> CC: Neil Horman <nhorman@...driver.com> CC: Greg Kroah-Hartman <gregkh@...uxfoundation.org> CC: linux-pci@...r.kernel.org CC: linux-kernel@...r.kernel.org Signed-off-by: Veaceslav Falico <vfalico@...hat.com> --- Notes: v1 -> v2: Verify if the kset was actually register before unregistering. drivers/pci/msi.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/pci/msi.c b/drivers/pci/msi.c index 0771508..dafda2b 100644 --- a/drivers/pci/msi.c +++ b/drivers/pci/msi.c @@ -391,6 +391,11 @@ static void free_msi_irqs(struct pci_dev *dev) kfree(entry); } } + + if (dev->msi_kset) { + kset_unregister(dev->msi_kset); + dev->msi_kset = NULL; + } } static struct msi_desc *alloc_msi_entry(struct pci_dev *dev) @@ -904,8 +909,6 @@ void pci_disable_msi(struct pci_dev *dev) pci_msi_shutdown(dev); free_msi_irqs(dev); - kset_unregister(dev->msi_kset); - dev->msi_kset = NULL; } EXPORT_SYMBOL(pci_disable_msi); @@ -1002,8 +1005,6 @@ void pci_disable_msix(struct pci_dev *dev) pci_msix_shutdown(dev); free_msi_irqs(dev); - kset_unregister(dev->msi_kset); - dev->msi_kset = NULL; } EXPORT_SYMBOL(pci_disable_msix); -- 1.8.4 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists