linux-kernel - Re: [RFC][PATCH 0/4] SunRPC/NFS: Use no

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130926152125.GD704@fieldses.org>
Date:	Thu, 26 Sep 2013 11:21:26 -0400
From:	"J. Bruce Fields" <bfields@...ldses.org>
To:	David Howells <dhowells@...hat.com>
Cc:	Trond.Myklebust@...app.com, olof@...om.net,
	linux-nfs@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [RFC][PATCH 0/4] SunRPC/NFS: Use no_printk() in

On Thu, Sep 26, 2013 at 03:45:02PM +0100, David Howells wrote:
> 
> 
> Here's a series of patches to make SunRPC/NFS use no_printk() to implement its
> null dfprintk() macro (ie. when RPC_DEBUG is disabled).  This prevents 'unused
> variable' errors from occurring when a variable is set only for use in
> debugging statements and renders RPC/NFS_IFDEBUG unnecessary.

Does this patch series fix any actual warnings?  Or does it just change
the way that we prevent the warnings?

Whatever, I've got no opinion--ACK for any parts that touch code I
maintain....

--b.

> 
> David
> ---
> David Howells (4):
>       SunRPC: Use the standard varargs macro method for dfprintk() and co.
>       SunRPC: Declare and use rpc_task_pid() to wrap task->tk_pid
>       SunRPC: Use no_printk() for the null dprintk() and dfprintk()
>       SunRPC: Kill RPC_IFDEBUG() and NFS_IFDEBUG()
> 
> 
>  fs/lockd/clntproc.c            |    2 +
>  fs/lockd/svc.c                 |    6 ++-
>  fs/lockd/svc4proc.c            |    2 +
>  fs/lockd/svclock.c             |    6 ++-
>  fs/lockd/svcproc.c             |    2 +
>  fs/nfs/direct.c                |    6 ++-
>  fs/nfs/fscache.c               |    2 +
>  fs/nfs/nfs4filelayout.c        |    8 ++--
>  fs/nfs/nfs4proc.c              |    2 +
>  fs/nfs/read.c                  |    4 +-
>  fs/nfs/write.c                 |    8 ++--
>  fs/nfsd/nfs4proc.c             |    6 +--
>  fs/nfsd/nfsfh.c                |   10 +++---
>  include/linux/nfs_fs.h         |    2 -
>  include/linux/sunrpc/debug.h   |   39 ++++++++++------------
>  include/linux/sunrpc/sched.h   |   20 ++++++++---
>  include/trace/events/sunrpc.h  |    8 ++--
>  net/sunrpc/auth.c              |   18 +++++-----
>  net/sunrpc/auth_gss/auth_gss.c |   20 ++++++-----
>  net/sunrpc/clnt.c              |   72 ++++++++++++++++++++--------------------
>  net/sunrpc/rpcb_clnt.c         |   34 +++++++++----------
>  net/sunrpc/sched.c             |   39 +++++++++-------------
>  net/sunrpc/svcsock.c           |   33 +++++++++++-------
>  net/sunrpc/xprt.c              |   30 ++++++++---------
>  net/sunrpc/xprtsock.c          |    2 +
>  25 files changed, 194 insertions(+), 187 deletions(-)
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/