linux-kernel - Re: [PATCH staging] dgnc: remove useless cast on kzalloc()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130926162757.GA10468@kroah.com>
Date:	Thu, 26 Sep 2013 09:27:57 -0700
From:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:	Fengguang Wu <fengguang.wu@...el.com>
Cc:	Lidza Louina <lidza.louina@...il.com>, kbuild-all@...org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH staging] dgnc: remove useless cast on kzalloc()

On Thu, Sep 26, 2013 at 10:12:23AM +0800, Fengguang Wu wrote:
> drivers/staging/dgnc/dgnc_driver.c:510:3-7: WARNING: casting value returned by k[cmz]alloc to (char *) is useless.
> drivers/staging/dgnc/dgnc_driver.c:502:2-19: WARNING: casting value returned by k[cmz]alloc to (struct dgnc_board *) is useless.
> 
>  Casting (void *) value returned by kmalloc is useless
>  as mentioned in Documentation/CodingStyle, Chap 14.
> 
> Generated by: coccinelle/api/alloc/drop_kmalloc_cast.cocci
> 
> CC: Lidza Louina <lidza.louina@...il.com>
> CC: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> Signed-off-by: Fengguang Wu <fengguang.wu@...el.com>
> ---
> 
>  drivers/staging/dgnc/dgnc_driver.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

As Jingoo sent this a few minutes before you did, and also cleaned up
another cast that you missed, I've added your signed-off-by to his
patch, as they were the same (although yours didn't apply and his
did...)

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/