linux-kernel - Re: [dtc PATCH V2] Warn on node name unit-address presence/absence mismatch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5244BF7A.4000100@wwwdotorg.org>
Date:	Thu, 26 Sep 2013 17:12:58 -0600
From:	Stephen Warren <swarren@...dotorg.org>
To:	Kumar Gala <galak@...eaurora.org>
CC:	Jon Loeliger <jdl@....com>,
	David Gibson <david@...son.dropbear.id.au>,
	Olof Johansson <olof@...om.net>, frowand.list@...il.com,
	Tomasz Figa <tomasz.figa@...il.com>,
	Benjamin Herrenschmidt <benh@...nel.crashing.org>,
	devicetree@...r.kernel.org,
	Linux Kernel list <linux-kernel@...r.kernel.org>,
	Marek Szyprowski <m.szyprowski@...sung.com>,
	Rob Herring <rob.herring@...xeda.com>,
	Grant Likely <grant.likely@...retlab.ca>,
	Stephen Warren <swarren@...dia.com>,
	Rohit Vaswani <rvaswani@...eaurora.org>
Subject: Re: [dtc PATCH V2] Warn on node name unit-address presence/absence
 mismatch

On 09/26/2013 12:21 PM, Kumar Gala wrote:
> 
> On Sep 19, 2013, at 12:54 PM, Stephen Warren wrote:
> 
>> From: Stephen Warren <swarren@...dia.com>
>>
>> ePAPR 1.1 section 2.2.1.1 "Node Name Requirements" specifies that any
>> node that has a reg property must include a unit address in its name
>> with value matching the first entry in its reg property. Conversely, if
>> a node does not have a reg property, the node name must not include a
>> unit address.
>>
>> Implement a check for this. The code doesn't validate the format of the
>> unit address; ePAPR implies this may vary from (containing bus) binding
>> to binding, so doing so would be much more complex.

> What about the case of no reg but a ranges?
> 
> This pattern shows up on a lot (if not all) the PPC dts:
> 
> arch/powerpc/boot/dts/mpc8544ds.dts:
> 
>         board_soc: soc: soc8544@...00000 {
>                 ranges = <0x0 0x0 0xe0000000 0x100000>;

Well, ePAPR seems pretty specific that unit address and reg are related,
but says nothing about ranges in the section on node naming, nor about
node naming in the section about ranges.

I'd claim that the existing PPC trees are nonconforming, and should be
fixed too:-)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/