linux-kernel - Re: [GIT PULL] ARM: SoC fixes for 3.12-rc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 27 Sep 2013 10:59:16 +0000
From:	"Woodhouse, David" <david.woodhouse@...el.com>
To:	Brian Norris <computersforpeace@...il.com>
CC:	Olof Johansson <olof@...om.net>,
	"torvalds@...ux-foundation.org" <torvalds@...ux-foundation.org>,
	"arm@...nel.org" <arm@...nel.org>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-mtd@...ts.infradead.org" <linux-mtd@...ts.infradead.org>
Subject: Re: [GIT PULL] ARM: SoC fixes for 3.12-rc

On Thu, 2013-09-19 at 17:44 -0700, Brian Norris wrote:
> > Does that m25p80 'fix 4 byte addressing' fix for Micron not also want to
> > go in?
> 
> I suppose the m25p80 one can go in as well. It's not so much a bugfix
> as augmenting my original patch to support more devices. But it is
> safe enough.

You say 'support more devices', but AFAICT the code in -rc1 will already
*attempt* to enable 4-byte addressing on those devices, and fail.

(It looks like set_4byte() can return failure, but its return code isn't
checked, and anyway it's only a SPI write so there's no feedback from
the *chip* if it fails due to lack of WREN; it can only indicate failure
if the SPI connection falls over.)

So I'm inclined to think of it as a bug fix and include it.

-- 
David Woodhouse                            Open Source Technology Centre
David.Woodhouse@...el.com                              Intel Corporation

Download attachment "smime.p7s" of type "application/x-pkcs7-signature" (6242 bytes)