linux-kernel - Re: [PATCHv4 11/18] arm: dts: add omap4430 thermal data

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 27 Sep 2013 08:26:35 -0500
From:	Nishanth Menon <nm@...com>
To:	Eduardo Valentin <eduardo.valentin@...com>
Cc:	Mark Rutland <mark.rutland@....com>,
	dt list <devicetree@...r.kernel.org>, wni@...dia.com,
	durgadoss.r@...el.com, Ian Campbell <ian.campbell@...rix.com>,
	Pawel Moll <pawel.moll@....com>,
	Stephen Warren <swarren@...dotorg.org>,
	Tony Lindgren <tony@...mide.com>,
	devicetree-discuss@...ts.ozlabs.org, linux-pm@...r.kernel.org,
	lkml <linux-kernel@...r.kernel.org>,
	Rob Herring <rob.herring@...xeda.com>,
	lm-sensors@...sensors.org,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	Benoît Cousson <bcousson@...libre.com>,
	Grant Likely <grant.likely@...aro.org>,
	Russell King <linux@....linux.org.uk>, rui.zhang@...el.com,
	linux-omap <linux-omap@...r.kernel.org>, linux@...ck-us.net
Subject: Re: [PATCHv4 11/18] arm: dts: add omap4430 thermal data

On Fri, Sep 27, 2013 at 8:20 AM, Eduardo Valentin
<eduardo.valentin@...com> wrote:
> On 27-09-2013 08:24, Nishanth Menon wrote:
>> On 23:13-20130926, Eduardo Valentin wrote:
>>> This patch changes the dtsi entry on omap4430 to contain
>>> the thermal data. This data will enable the passive
>>> cooling with CPUfreq cooling device at 100C and the
>>> system will do a thermal shutdown at 125C.
>>>
>>> Cc: "Benoît Cousson" <bcousson@...libre.com>
>>> Cc: Tony Lindgren <tony@...mide.com>
>>> Cc: Russell King <linux@....linux.org.uk>
>>> Cc: linux-omap@...r.kernel.org
>>> Cc: devicetree-discuss@...ts.ozlabs.org
>>> Cc: linux-arm-kernel@...ts.infradead.org
>>> Cc: linux-kernel@...r.kernel.org
>>> Signed-off-by: Eduardo Valentin <eduardo.valentin@...com>
>>> ---
>>>  arch/arm/boot/dts/omap443x.dtsi | 10 ++++++++--
>>>  1 file changed, 8 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/arch/arm/boot/dts/omap443x.dtsi b/arch/arm/boot/dts/omap443x.dtsi
>>> index bcf455e..e9c97d6 100644
>>> --- a/arch/arm/boot/dts/omap443x.dtsi
>>> +++ b/arch/arm/boot/dts/omap443x.dtsi
>>> @@ -12,7 +12,7 @@
>>>
>>>  / {
>>>      cpus {
>>> -            cpu@0 {
>>> +            cpu0: cpu@0 {
>>>                      /* OMAP443x variants OPP50-OPPNT */
>>>                      operating-points = <
>>>                              /* kHz    uV */
>>> @@ -25,9 +25,15 @@
>>>              };
>>>      };
>>>
>>> -    bandgap {
>>> +    thermal-zones{
>>> +            #include "omap4-cpu-thermal.dtsi"
>>> +    };
>>> +
>>> +    bandgap: bandgap {
>>>              reg = <0x4a002260 0x4
>>>                     0x4a00232C 0x4>;
>>>              compatible = "ti,omap4430-bandgap";
>>> +
>>> +            #thermal-sensor-cells = <0>;
>> 2 cents:
>> we might want to move bandgap under ocp?
>>
>
> Yes, agreed. But I don't think this change is related to this patch or
> to this series.

Correct - this comment is not related to the current patch, hence my 2
cents ;) - will be nice to have it cleaned up though..

Regards,
Nishanth Menon
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/