linux-kernel - Re: [PATCH 1/2] pinctrl: palmas: do not abort pin configuration for BIAS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACRpkdZ=KK6YY0_HFDyieg9_WiqabxrQb4gLYgmiOnKBDU6SKw@mail.gmail.com>
Date:	Fri, 27 Sep 2013 16:25:13 +0200
From:	Linus Walleij <linus.walleij@...aro.org>
To:	Laxman Dewangan <ldewangan@...dia.com>
Cc:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Sherman Yin <syin@...adcom.com>
Subject: Re: [PATCH 1/2] pinctrl: palmas: do not abort pin configuration for BIAS_DEFAULT

On Thu, Sep 26, 2013 at 2:48 PM, Laxman Dewangan <ldewangan@...dia.com> wrote:

> Recent movement of all configurations of pin in the single call of
> pin_config_set(), it is aborting configuration if BIAS_PULL_PIN_DEFAULT
> is selected as return of configuration.
>
> The original idea was to just avoid any update on register for pull up/down
> configuration if this option is selected.
>
> Fixing this by just bypassing any register update for BIAS_PULL_PIN_DEFAULT
> and continuing the remaining configuration.
>
> Signed-off-by: Laxman Dewangan <ldewangan@...dia.com>

I've applied the patch as it just brings back the semantics before
commit 03b054e9696c3cbd3d5905ec96da15acd0a2fe8d
"pinctrl: Pass all configs to driver on pin_config_set()"

(Normally you should mention the above in your commit message
with patches like these that are regressions.)
But whatever.

Please look into the related issue pointed out by Stephen as well.

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/