linux-kernel - Re: [PATCH] USB: gadget: epautoconf: fix ep maxpacket check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.44L0.1309271126490.10254-100000@netrider.rowland.org>
Date:	Fri, 27 Sep 2013 11:32:45 -0400 (EDT)
From:	Alan Stern <stern@...land.harvard.edu>
To:	Robert Baldyga <r.baldyga@...sung.com>
cc:	balbi@...com, <gregkh@...uxfoundation.org>,
	<linux-usb@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
	<b.zolnierkie@...sung.com>, <m.szyprowski@...sung.com>,
	<andrzej.p@...sung.com>
Subject: Re: [PATCH] USB: gadget: epautoconf: fix ep maxpacket check

On Fri, 27 Sep 2013, Robert Baldyga wrote:

> This patch fixes validation of maxpacket value given in endpoint descriptor.
> Added check of maxpacket for bulk endpoints.
> Correct maxpacket value is:
> 
>              FULL-SPEED  HIGH-SPEED
> BULK         64          512

Don't forget SuperSpeed.  It requires Bulk endpoints to have maxpacket 
= 1024.

> INTERRUPT    64          1024
> ISOCHRONOUS  1023        1024
> 
> Signed-off-by: Robert Baldyga <r.baldyga@...sung.com>
> ---
>  drivers/usb/gadget/epautoconf.c |   16 +++++++++++++---
>  1 file changed, 13 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/usb/gadget/epautoconf.c b/drivers/usb/gadget/epautoconf.c
> index a777f7b..35bde34 100644
> --- a/drivers/usb/gadget/epautoconf.c
> +++ b/drivers/usb/gadget/epautoconf.c
> @@ -136,16 +136,26 @@ ep_matches (
>  	 * the usb spec fixes high speed bulk maxpacket at 512 bytes.
>  	 */
>  	max = 0x7ff & usb_endpoint_maxp(desc);
> +	
> +	if (ep->maxpacket < max)
> +		return 0;
> +	
>  	switch (type) {
> +	case USB_ENDPOINT_XFER_BULK:
> +		/* BULK:  limit 512 high/super speed */

512 high, 1024 super.

> +		if (max > 512)
> +			return 0;
> +		/* FALLTHROUGH */
> +		
>  	case USB_ENDPOINT_XFER_INT:
> -		/* INT:  limit 64 bytes full speed, 1024 high/super speed */
> +		/* BULK/INT:  limit 64 bytes full speed */
>  		if (!gadget_is_dualspeed(gadget) && max > 64)
>  			return 0;
>  		/* FALLTHROUGH */
>  
>  	case USB_ENDPOINT_XFER_ISOC:
> -		/* ISO:  limit 1023 bytes full speed, 1024 high/super speed */
> -		if (ep->maxpacket < max)
> +		/* INT/ISO:  limit 1023 bytes full speed, 1024 high/super speed */

The comment mentions INT/ISO.  But this code can also run in the BULK
case.

> +		if (max > 1024)
>  			return 0;
>  		if (!gadget_is_dualspeed(gadget) && max > 1023)
>  			return 0;

I suspect this code would become a lot clearer if all the FALLTHROUGH 
logic were eliminated and each case was handled on its own.

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/