linux-kernel - Re: [PATCH] gma500: define do_gma_backlight

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 27 Sep 2013 05:12:29 +0200
From:	Patrik Jakobsson <patrik.r.jakobsson@...il.com>
To:	Vincent Stehlé <vincent.stehle@...oste.net>
Cc:	dri-devel <dri-devel@...ts.freedesktop.org>,
	linux-kernel <linux-kernel@...r.kernel.org>,
	David Airlie <airlied@...ux.ie>
Subject: Re: [PATCH] gma500: define do_gma_backlight_set only when used

On Thu, Sep 26, 2013 at 11:46 PM, Vincent Stehlé
<vincent.stehle@...oste.net> wrote:
> Make sure static function do_gma_backlight_set() is only defined when
> CONFIG_BACKLIGHT_CLASS_DEVICE is defined, as it is never called otherwise.
>
> This fixes the following warning:
>
>   drivers/gpu/drm/gma500/backlight.c:29:13: warning: ‘do_gma_backlight_set’ defined but not used [-Wunused-function]
>
> While at it, remove some end of line spaces.
>
> Signed-off-by: Vincent Stehlé <vincent.stehle@...oste.net>
> Cc: David Airlie <airlied@...ux.ie>
> ---
>
> Hi,
>
> This can be seen with mainline or linux-next with e.g. allmodconfig on x86.
>
> Best regards,
>
> V.
>
>  drivers/gpu/drm/gma500/backlight.c | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/gpu/drm/gma500/backlight.c b/drivers/gpu/drm/gma500/backlight.c
> index 143eba3..399731e 100644
> --- a/drivers/gpu/drm/gma500/backlight.c
> +++ b/drivers/gpu/drm/gma500/backlight.c
> @@ -26,13 +26,13 @@
>  #include "intel_bios.h"
>  #include "power.h"
>
> +#ifdef CONFIG_BACKLIGHT_CLASS_DEVICE
>  static void do_gma_backlight_set(struct drm_device *dev)
>  {
> -#ifdef CONFIG_BACKLIGHT_CLASS_DEVICE
>         struct drm_psb_private *dev_priv = dev->dev_private;
>         backlight_update_status(dev_priv->backlight_device);
> -#endif
>  }
> +#endif
>
>  void gma_backlight_enable(struct drm_device *dev)
>  {
> @@ -43,7 +43,7 @@ void gma_backlight_enable(struct drm_device *dev)
>                 dev_priv->backlight_device->props.brightness = dev_priv->backlight_level;
>                 do_gma_backlight_set(dev);
>         }
> -#endif
> +#endif
>  }
>
>  void gma_backlight_disable(struct drm_device *dev)
> @@ -55,7 +55,7 @@ void gma_backlight_disable(struct drm_device *dev)
>                 dev_priv->backlight_device->props.brightness = 0;
>                 do_gma_backlight_set(dev);
>         }
> -#endif
> +#endif
>  }
>
>  void gma_backlight_set(struct drm_device *dev, int v)
> @@ -67,7 +67,7 @@ void gma_backlight_set(struct drm_device *dev, int v)
>                 dev_priv->backlight_device->props.brightness = v;
>                 do_gma_backlight_set(dev);
>         }
> -#endif
> +#endif
>  }
>
>  int gma_backlight_init(struct drm_device *dev)
> --
> 1.8.4.rc3

Thanks, looks good, I'll apply it to the gma500-fixes branch.

Acked-by: Patrik Jakobsson <patrik.r.jakobsson@...il.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/