linux-kernel - Re: [PATCH 1/1] AHCI: disabled FBS prior to issuing software reset

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAP0P+NUvaLfXkOUGm8NX19AHvTHmU=Ya0NdFvyJc2gFjN-Cy0A@mail.gmail.com>
Date:	Sat, 28 Sep 2013 21:04:15 +0800
From:	xiangliang yu <yxlraid@...il.com>
To:	Tejun Heo <tj@...nel.org>
Cc:	linux-ide@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/1] AHCI: disabled FBS prior to issuing software reset

hi, Tejun
i had tested the patch with Marvell 88se9235. And driver can find disk
if FBS disabled, or can't find disk.
Please see chapter 9.3.9 and 9.3.8 of AHCI spec. Thanks.


2013/9/28 Tejun Heo <tj@...nel.org>:
> Hello,
>
> On Sat, Sep 28, 2013 at 07:13:36PM +0800, Xiangliang Yu wrote:
>> If device is attached to port multiplier, the detection process
>> look like this:
>>       ahci_hardreset(link, class, deadline)
>>       if (class == ATA_DEV_PMP) {
>>               sata_pmp_attach(dev)    /* will enable FBS */
>>               sata_pmp_init_links(ap, nr_ports);
>>               ata_for_each_link(link, ap, EDGE) {
>>                       sata_std_hardreset(link, class, deadline);
>>                       if (link_is_online)
>>                               ahci_softreset(link, class, deadline);
>>               }
>>       }
>> But, according to chapter 9.3.9 in AHCI spec: Prior to issuing software reset,
>> software shall clear PxCMD.ST to '0' and then clear PxFBS.EN to '0'.
>
> How was this tested?  Do you observe any behavior difference?  At this
> point, we are not using SRST on PMP ports anyway, so I can't see how
> this would make any difference.
>
> Thanks.
>
> --
> tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/