linux-kernel - Re: [PATCH] x86, boot: Further compress CPUs bootup message

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130928175444.GA4402@gmail.com>
Date:	Sat, 28 Sep 2013 19:54:44 +0200
From:	Ingo Molnar <mingo@...nel.org>
To:	Borislav Petkov <bp@...en8.de>
Cc:	hpa@...or.com, linux-kernel@...r.kernel.org,
	huawei.libin@...wei.com, wangyijing@...wei.com,
	fenghua.yu@...el.com, tglx@...utronix.de, guohanjun@...wei.com,
	paul.gortmaker@...driver.com, linux-tip-commits@...r.kernel.org
Subject: Re: [PATCH] x86, boot: Further compress CPUs bootup message


* Borislav Petkov <bp@...en8.de> wrote:

> +void smp_announce(void)
> +{
> +	int num_nodes = num_online_nodes();
> +
> +	printk(KERN_INFO "x86: Booted up %d node%s, %ld CPUs\n",
> +	       num_nodes, (num_nodes > 1 ? "s" : ""), (long)num_online_cpus());
> +}

That (long) cast looks weird - num_online_cpus() is 'unsigned int' so 
changing the format to %d should do the trick, right?

> +void __weak smp_announce(void)
> +{
> +	printk(KERN_INFO "Brought up %ld CPUs\n", (long)num_online_cpus());
> +}

Ditto.

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/