linux-kernel - [PATCH] staging/olpc: fix dependencies to fix build errors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <52461F0B.5070303@infradead.org>
Date:	Fri, 27 Sep 2013 17:12:59 -0700
From:	Randy Dunlap <rdunlap@...radead.org>
To:	akpm@...ux-foundation.org
CC:	linux-kernel@...r.kernel.org,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Daniel Drake <dsd@...top.org>,
	Jens Frederich <jfrederich@...il.com>,
	"devel@...verdev.osuosl.org" <devel@...verdev.osuosl.org>
Subject: [PATCH] staging/olpc: fix dependencies to fix build errors

From: Randy Dunlap <rdunlap@...radead.org>

Fix build errors when GPIO_CS5535=m and FB_OLPC_DCON=y
by preventing that kconfig combination.

These build errors are caused by having a kconfig bool symbol
(FB_OLPC_DCON_1) that depend on a tristate symbol (GPIO_CS5535),
but when the tristate symbol is =m, the bool symbol is =y.

drivers/built-in.o: In function `dcon_read_status_xo_1':
olpc_dcon_xo_1.c:(.text+0x359531): undefined reference to `cs5535_gpio_set'
drivers/built-in.o: In function `dcon_wiggle_xo_1':
olpc_dcon_xo_1.c:(.text+0x35959f): undefined reference to `cs5535_gpio_set'
olpc_dcon_xo_1.c:(.text+0x359610): undefined reference to `cs5535_gpio_clear'
drivers/built-in.o:olpc_dcon_xo_1.c:(.text+0x3596a1): more undefined references to `cs5535_gpio_clear' follow
drivers/built-in.o: In function `dcon_wiggle_xo_1':
olpc_dcon_xo_1.c:(.text+0x359708): undefined reference to `cs5535_gpio_set'
drivers/built-in.o: In function `dcon_init_xo_1':
olpc_dcon_xo_1.c:(.text+0x35989b): undefined reference to `cs5535_gpio_clear'
olpc_dcon_xo_1.c:(.text+0x3598b5): undefined reference to `cs5535_gpio_isset'
olpc_dcon_xo_1.c:(.text+0x359963): undefined reference to `cs5535_gpio_setup_event'
olpc_dcon_xo_1.c:(.text+0x359980): undefined reference to `cs5535_gpio_set_irq'
olpc_dcon_xo_1.c:(.text+0x359a36): undefined reference to `cs5535_gpio_set'

Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
Cc:	Daniel Drake <dsd@...top.org>
Cc:	Jens Frederich <jfrederich@...il.com>
---
This build problem has been around for a long time and is not
specific to mmotm.

 drivers/staging/olpc_dcon/Kconfig |    1 +
 1 file changed, 1 insertion(+)

--- mmotm-2013-0926-1615.orig/drivers/staging/olpc_dcon/Kconfig
+++ mmotm-2013-0926-1615/drivers/staging/olpc_dcon/Kconfig
@@ -1,6 +1,7 @@
 config FB_OLPC_DCON
 	tristate "One Laptop Per Child Display CONtroller support"
 	depends on OLPC && FB
+	depends on (GPIO_CS5535 || GPIO_CS5535=n)
 	select I2C
 	select BACKLIGHT_CLASS_DEVICE
 	---help---
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/