linux-kernel - Re: [PATCH] misc: cs5535-mfgpt: Replace 'module_init' with 'module_platform

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <524756D7.2020301@nod.at>
Date:	Sun, 29 Sep 2013 00:23:19 +0200
From:	Richard Weinberger <richard@....at>
To:	Elad Wexler <elad.wexler@...il.com>
CC:	arnd@...db.de, gregkh@...uxfoundation.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] misc: cs5535-mfgpt: Replace 'module_init' with 'module_platform_driver'

Am 29.09.2013 00:14, schrieb Elad Wexler:
> On Sat, Sep 28, 2013 at 08:54:55PM +0200, richard -rw- weinberger wrote:
>> On Sat, Sep 28, 2013 at 8:14 PM,  <elad.wexler@...il.com> wrote:
>>> From: Elad Wexler <elad.wexler@...il.com>
>>>
>>> Driver doesn't do anything special in 'module_init'.
>>>
>>> 'module_platform_init' makes the code more readable.
>>>
>>> Signed-off-by: Elad Wexler <elad.wexler@...il.com>
>>
>> NAK.
>>
>> By moving to module_platform_init() you make this module unloadable.
>> Currently it is unloadable for good reasons.
>> The cs5535-mfgpt chip is nasty because it has no reliable reset function.
>> Therefore by unloading and loading the module again bad things can happen.
>>
> I think this HW information should be well documented.
> Explaining the reason why it doesn't implemented the 'module_exit'

Usually if a driver does not implement the exit function it's because of hardware
limitations.
IOW, the alarm bell rings. ;-)

Thanks,
//richard
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/