linux-kernel - Re: [PATCH] HID: roccat: Fix "cannot create duplicate filename" problems

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130928040257.GA21630@kroah.com>
Date:	Fri, 27 Sep 2013 21:02:57 -0700
From:	Greg KH <gregkh@...uxfoundation.org>
To:	Stefan Achatz <erazor_de@...rs.sourceforge.net>
Cc:	Jiri Kosina <jkosina@...e.cz>, linux-input@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] HID: roccat: Fix "cannot create duplicate filename"
 problems

On Sat, Sep 28, 2013 at 05:57:46AM +0200, Stefan Achatz wrote:
> Fixing some wrong macro stringification/concatenation.
> 
> Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> Signed-off-by: Stefan Achatz <erazor_de@...rs.sourceforge.net>
> ---
>  drivers/hid/hid-roccat-kone.c     |    2 +-
>  drivers/hid/hid-roccat-koneplus.c |    4 ++--
>  drivers/hid/hid-roccat-kovaplus.c |    4 ++--
>  drivers/hid/hid-roccat-pyra.c     |    4 ++--
>  4 files changed, 7 insertions(+), 7 deletions(-)
> 
> diff --git a/drivers/hid/hid-roccat-kone.c b/drivers/hid/hid-roccat-kone.c
> index 602c188..6101816 100644
> --- a/drivers/hid/hid-roccat-kone.c
> +++ b/drivers/hid/hid-roccat-kone.c
> @@ -382,7 +382,7 @@ static ssize_t kone_sysfs_write_profilex(struct file *fp,
>  }
>  #define PROFILE_ATTR(number)					\
>  static struct bin_attribute bin_attr_profile##number = {	\
> -	.attr = { .name = "profile##number", .mode = 0660 },	\
> +	.attr = { .name = "profile" #number, .mode = 0660 },	\

Ugh, very sorry about that, I hate macros in C at times :)

Jiri, can you take this through your tree, or I can if you want, it
needs to go in for 3.12-final.

If yours, feel free to add:

Acked-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>

Stefan, thanks for fixing my bugs, it's much appreciated.

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/