linux-kernel - Re: [PATCH] ARM: mach-iop32x: iq31244: Replace if-then-else with a switch statement

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHuBVBbDk_bgJ9-R-tr9qrt7O3i6NEF6m2QeWnpU5UCxPC9DrA@mail.gmail.com>
Date:	Sun, 29 Sep 2013 18:19:28 +0300
From:	Valentin Ilie <valentin.ilie@...il.com>
To:	linux@....linux.org.uk
Cc:	swarren@...dia.com, rmk+kernel@....linux.org.uk,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
	Valentin Ilie <valentin.ilie@...il.com>
Subject: Re: [PATCH] ARM: mach-iop32x: iq31244: Replace if-then-else with a
 switch statement

On 2 September 2013 18:23, Valentin Ilie <valentin.ilie@...il.com> wrote:
> Convert a compound if-else blob to a switch statement.
>
> Signed-off-by: Valentin Ilie <valentin.ilie@...il.com>
> ---
>  arch/arm/mach-iop32x/iq31244.c | 29 +++++++++++------------------
>  1 file changed, 11 insertions(+), 18 deletions(-)
>
> diff --git a/arch/arm/mach-iop32x/iq31244.c b/arch/arm/mach-iop32x/iq31244.c
> index f2cd296..3415f11 100644
> --- a/arch/arm/mach-iop32x/iq31244.c
> +++ b/arch/arm/mach-iop32x/iq31244.c
> @@ -101,28 +101,21 @@ void __init iq31244_map_io(void)
>  static int __init
>  ep80219_pci_map_irq(const struct pci_dev *dev, u8 slot, u8 pin)
>  {
> -       int irq;
> -
> -       if (slot == 0) {
> -               /* CFlash */
> -               irq = IRQ_IOP32X_XINT1;
> -       } else if (slot == 1) {
> -               /* 82551 Pro 100 */
> -               irq = IRQ_IOP32X_XINT0;
> -       } else if (slot == 2) {
> -               /* PCI-X Slot */
> -               irq = IRQ_IOP32X_XINT3;
> -       } else if (slot == 3) {
> -               /* SATA */
> -               irq = IRQ_IOP32X_XINT2;
> -       } else {
> +       switch (slot) {
> +       case 0: /* CFlash */
> +               return IRQ_IOP32X_XINT1;
> +       case 1: /* 82551 Pro 100 */
> +               return IRQ_IOP32X_XINT0;
> +       case 2: /* PCI-X Slot */
> +               return IRQ_IOP32X_XINT3;
> +       case 3: /* SATA */
> +               return IRQ_IOP32X_XINT2;
> +       default:
>                 printk(KERN_ERR "ep80219_pci_map_irq() called for unknown "
>                         "device PCI:%d:%d:%d\n", dev->bus->number,
>                         PCI_SLOT(dev->devfn), PCI_FUNC(dev->devfn));
> -               irq = -1;
> +               return -1;
>         }
> -
> -       return irq;
>  }
>
>  static struct hw_pci ep80219_pci __initdata = {
> --
> 1.8.1.2
>

Can someone look into this?

-- 
Valentin Ilie
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/