| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Mon, 30 Sep 2013 10:52:02 +0100 From: Charles Keepax <ckeepax@...nsource.wolfsonmicro.com> To: Chanwoo Choi <cw00.choi@...sung.com> Cc: myungjoo.ham@...sung.com, broonie@...nel.org, patches@...nsource.wolfsonmicro.com, linux-kernel@...r.kernel.org Subject: Re: [PATCH] extcon: arizona: Get pdata from arizona structure not device On Mon, Sep 30, 2013 at 08:37:30AM +0900, Chanwoo Choi wrote: > No, extcon-arizona driver don't currently support DT to get platform data. > I cannot find some dt function to parse data from dts file. > You have to implement extcon-arizona driver by using DT binding style > to get platform data. I think this patch is not necessary. Currently the Arizona MFD driver reads the device tree information and populates the pdata structure, this happens in drivers/mfd/arizona-core.c. Then the various drivers just use the pdata as normal. Admittedly, at the moment we don't parse any data for the extcon driver but without this patch we will attempt to use a NULL pointer on device tree systems. I would also be happy to implement this as a NULL check on the pdata when we use it if that is preferable? But since we have the cached pdata seems we might as well use it. Thanks, Charles -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists