linux-kernel - Re: [PATCH 1/2] regulator: ti-abb: Remove redundant of_match

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130930110125.GY19304@sirena.org.uk>
Date:	Mon, 30 Sep 2013 12:01:25 +0100
From:	Mark Brown <broonie@...nel.org>
To:	Sachin Kamat <sachin.kamat@...aro.org>
Cc:	linux-kernel@...r.kernel.org, lgirdwood@...il.com
Subject: Re: [PATCH 1/2] regulator: ti-abb: Remove redundant of_match_ptr

On Mon, Sep 30, 2013 at 02:27:13PM +0530, Sachin Kamat wrote:
> The data structure of_match_ptr() protects is always compiled in.
> Hence of_match_ptr() is not needed.

It seems like good practice to include these even if they're not
currently doing anything - for example, if ACPI support were added to
the driver then you could get an ACPI kernel OF disabled.

Note that one of the things these macros are supposed to do (but don't
yet IIRC) is allow for dead code elimination to discard references to
things automatically even without the being ifdefed out.

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)