linux-kernel - Re: [RFC PATCH] tty: serial: uartlite: Extend time for sending chars through mdm IP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 30 Sep 2013 05:54:33 -0700
From:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:	Michal Simek <michal.simek@...inx.com>
Cc:	linux-kernel@...r.kernel.org, Michal Simek <monstr@...str.eu>,
	linux-serial@...r.kernel.org, arnd@...db.de,
	Peter Korsgaard <jacmet@...site.dk>,
	Grant Likely <grant.likely@...retlab.ca>,
	Rob Herring <rob.herring@...xeda.com>,
	Jiri Slaby <jslaby@...e.cz>
Subject: Re: [RFC PATCH] tty: serial: uartlite: Extend time for sending chars
 through mdm IP

On Mon, Sep 30, 2013 at 01:50:35PM +0200, Michal Simek wrote:
> From: Michal Simek <monstr@...str.eu>
> 
> Serial over jtag via mdm is compatible with uartlite driver
> just need to extend time for reading chars because connection
> is slow.
> 
> Signed-off-by: Michal Simek <michal.simek@...inx.com>
> ---
>  drivers/tty/serial/uartlite.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/tty/serial/uartlite.c b/drivers/tty/serial/uartlite.c
> index 5f90ef2..f55c342 100644
> --- a/drivers/tty/serial/uartlite.c
> +++ b/drivers/tty/serial/uartlite.c
> @@ -422,7 +422,7 @@ static void ulite_console_wait_tx(struct uart_port *port)
>  	u8 val;
> 
>  	/* Spin waiting for TX fifo to have space available */
> -	for (i = 0; i < 100000; i++) {
> +	for (i = 0; i < 10000000; i++) {
>  		val = uart_in32(ULITE_STATUS, port);
>  		if ((val & ULITE_STATUS_TXFULL) == 0)
>  			break;

Ick, what happens next year when we get a faster cpu?

Please make this a time delay, not a 'loop till we can count to this
number', so we know exactly what is going on here.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/