linux-kernel - RE: [PATCH] powerpc/8xx: tqm8xx: fix incorrect placement of _

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <AE90C24D6B3A694183C094C60CF0A2F6026B736B@saturn3.aculab.com>
Date:	Mon, 30 Sep 2013 15:20:29 +0100
From:	"David Laight" <David.Laight@...LAB.COM>
To:	"Bartlomiej Zolnierkiewicz" <b.zolnierkie@...sung.com>,
	"Vitaly Bordug" <vitb@...nel.crashing.org>
Cc:	"Marcelo Tosatti" <marcelo@...ck.org>,
	"Kyungmin Park" <kyungmin.park@...sung.com>,
	<linuxppc-dev@...ts.ozlabs.org>, <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] powerpc/8xx: tqm8xx: fix incorrect placement of __initdata tag

> __initdata tag should be placed between the variable name and equal
> sign for the variable to be placed in the intended .init.data section.
...
> -static struct __initdata cpm_pin tqm8xx_pins[] = {
> +static struct cpm_pin tqm8xx_pins[] __initdata = {

As far as gcc is concerned it can go almost anywhere before the '=',
even before the 'static'.
Splitting 'struct cpm_pin' does seem an odd choice.

The Linux coding standards might suggest a location.
I'd have thought that either before or after the 'static' would be best
(ie as a storage class qualifier).

	David



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/