linux-kernel - Re: [PATCH 1/2] regulator: ti-abb: Remove redundant of_match

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20130930160844.GD19304@sirena.org.uk>
Date:	Mon, 30 Sep 2013 17:08:44 +0100
From:	Mark Brown <broonie@...nel.org>
To:	Sachin Kamat <sachin.kamat@...aro.org>
Cc:	LKML <linux-kernel@...r.kernel.org>,
	Liam Girdwood <lgirdwood@...il.com>
Subject: Re: [PATCH 1/2] regulator: ti-abb: Remove redundant of_match_ptr

On Mon, Sep 30, 2013 at 05:22:19PM +0530, Sachin Kamat wrote:
> On 30 September 2013 16:31, Mark Brown <broonie@...nel.org> wrote:

> > Note that one of the things these macros are supposed to do (but don't
> > yet IIRC) is allow for dead code elimination to discard references to
> > things automatically even without the being ifdefed out.

> Yes that is correct. However, in this particular case all that
> of_match_ptr() does
> is make the pointer NULL if CONFIG_OF is disabled else assign it as
> is. Since CONFIG_OF
> is not used in these files, I thought it would be an appropriate cleanup.

Yes, it's not a completely silly idea but unlike something like removing
totally empty functions it's something that doesn't cost us anything and
which we might want in future.  Right now the drivers only run on OF
systems though.

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)