linux-kernel - Re: Re: [PATCH -tip ] [BUGFIX] perf probe: Fix to find line information for probe list

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <52490CFE.6030409@hitachi.com>
Date:	Mon, 30 Sep 2013 14:32:46 +0900
From:	Masami Hiramatsu <masami.hiramatsu.pt@...achi.com>
To:	Namhyung Kim <namhyung@...nel.org>
Cc:	Arnaldo Carvalho de Melo <acme@...stprotocols.net>,
	Ingo Molnar <mingo@...hat.com>,
	Paul Mackerras <paulus@...ba.org>,
	lkml <linux-kernel@...r.kernel.org>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>
Subject: Re: Re: [PATCH -tip ] [BUGFIX] perf probe: Fix to find line information
 for probe list

(2013/09/30 14:08), Namhyung Kim wrote:
> Hi Masami,
> 
> Just a nitpick.
> 
> On Fri, 27 Sep 2013 15:57:07 +0900, Masami Hiramatsu wrote:
>>  /**
>> + * die_find_inlinefunc_next - Search an inlined function at given address
>> + * @cu_die: a CU DIE which including @addr
> 
> s/cu_die/sp_die/
> 
> And it doesn't look like a CU DIE, anyway.

Oops, right!
Thank you for review :)

> 
> 
> Thanks,
> Namhyung
> 
> 
>> + * @addr: target address
>> + * @die_mem: a buffer for result DIE
>> + *
>> + * Search an inlined function DIE which includes @addr. Stores the
>> + * DIE to @die_mem and returns it if found. Returns NULL if failed.
>> + * Even if several inlined functions are expanded recursively, this
>> + * doesn't trace it down, and returns the topmost one.
>> + */
>> +Dwarf_Die *die_find_inlinefunc_next(Dwarf_Die *sp_die, Dwarf_Addr addr,
>> +				    Dwarf_Die *die_mem)
>> +{
>> +	return die_find_child(sp_die, __die_find_inline_cb, &addr, die_mem);
>> +}


-- 
Masami HIRAMATSU
IT Management Research Dept. Linux Technology Center
Hitachi, Ltd., Yokohama Research Laboratory
E-mail: masami.hiramatsu.pt@...achi.com


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/