linux-kernel - Re: [PATCH] perf, tools: Fix sorting for 64bit entries

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87pprqoily.fsf@sejong.aot.lge.com>
Date:	Mon, 30 Sep 2013 16:48:25 +0900
From:	Namhyung Kim <namhyung@...nel.org>
To:	Andi Kleen <andi@...stfloor.org>
Cc:	acme@...radead.org, jolsa@...hat.com, eranian@...gle.com,
	linux-kernel@...r.kernel.org, namhyung.kim@....com,
	Andi Kleen <ak@...ux.intel.com>
Subject: Re: [PATCH] perf, tools: Fix sorting for 64bit entries

Hi Andi,

On Fri, 27 Sep 2013 16:39:24 -0700, Andi Kleen wrote:
> From: Andi Kleen <ak@...ux.intel.com>
>
> Some of the node comparisons in hist.c dropped the upper
> 32bit by using an int variable to store the compare
> result. This broke various 64bit fields, causing
> incorrect collapsing (found for the TSX transaction field)
>
> Just use int64_t always.

Acked-by: Namhyung Kim <namhyung@...nel.org>

Thanks,
Namhyung
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/