lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 1 Oct 2013 12:52:09 +0300 From: Mika Westerberg <mika.westerberg@...ux.intel.com> To: linux-i2c@...r.kernel.org Cc: Wolfram Sang <wsa@...-dreams.de>, rjw@...ysocki.net, Aaron Lu <aaron.lu@...el.com>, Lv Zheng <lv.zheng@...el.com>, Mark Brown <broonie@...nel.org>, Kevin Hilman <khilman@...aro.org>, Sylwester Nawrocki <s.nawrocki@...sung.com>, linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org, linux-acpi@...r.kernel.org Subject: Re: [PATCH v3] i2c: enable runtime PM for I2C adapter devices enumerated from ACPI On Mon, Sep 30, 2013 at 05:43:48PM +0300, Mika Westerberg wrote: > +static void acpi_i2c_device_pm_get(struct i2c_client *client) > +{ > + struct i2c_adapter *adap = client->adapter; > + > + /* Make sure the adapter is active */ > + if (ACPI_HANDLE(adap->dev.parent)) > + pm_runtime_get_sync(&adap->dev); > + if (ACPI_HANDLE(&client->dev)) > + acpi_dev_pm_attach(&client->dev, true); There's a bug here as we call acpi_dev_pm_attach() several times. It doesn't do any harm because acpi_dev_pm_attach() checks if the device is already attached to the ACPI domain or not. I'll fix this in the next revision as well. > +} -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists