linux-kernel - Re: [PATCH] x86/geode: fix incorrect placement of _

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-id: <4748759.pZGOv2NGcn@amdc1032>
Date:	Tue, 01 Oct 2013 12:37:47 +0200
From:	Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>
To:	Ingo Molnar <mingo@...nel.org>
Cc:	Thomas Gleixner <tglx@...utronix.de>,
	Ingo Molnar <mingo@...hat.com>,
	"H. Peter Anvin" <hpa@...or.com>, x86@...nel.org,
	linux-kernel@...r.kernel.org,
	Kyungmin Park <kyungmin.park@...sung.com>
Subject: Re: [PATCH] x86/geode: fix incorrect placement of __initdata tag


Hi,

On Tuesday, October 01, 2013 08:59:50 AM Ingo Molnar wrote:
> 
> * Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com> wrote:
> 
> > __initdata tag should be placed between the variable name and equal
> > sign for the variable to be placed in the intended .init.data section.
> > 
> > Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>
> > Signed-off-by: Kyungmin Park <kyungmin.park@...sung.com>
> > ---
> >  arch/x86/platform/geode/alix.c    | 2 +-
> >  arch/x86/platform/geode/geos.c    | 2 +-
> >  arch/x86/platform/geode/net5501.c | 2 +-
> >  3 files changed, 3 insertions(+), 3 deletions(-)
> 
> Does this fix have any runtime effects, i.e. should we queue this up as an 
> urgent fix for v3.12, or does tip:x86/platform with a v3.13 merge suffice?

It has runtime effects as the data now goes into .init.data which was not
a case previously. However it is not an urgent fix so I think that queuing
it for v3.13 is a better option. Thanks.

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/