linux-kernel - Re: [PATCH v5 1/3] usb: dwc3: msm: Add device tree binding information

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1380629114.30666.19.camel@iivanov-dev.int.mm-sol.com>
Date:	Tue, 01 Oct 2013 15:05:14 +0300
From:	"Ivan T. Ivanov" <iivanov@...sol.com>
To:	Stephen Warren <swarren@...dotorg.org>
Cc:	balbi@...com, rob.herring@...xeda.com, pawel.moll@....com,
	mark.rutland@....com, ian.campbell@...rix.com, rob@...dley.net,
	gregkh@...uxfoundation.org, grant.likely@...aro.org,
	idos@...eaurora.org, mgautam@...eaurora.org,
	devicetree@...r.kernel.org, linux-doc@...r.kernel.org,
	linux-kernel@...r.kernel.org, linux-usb@...r.kernel.org,
	linux-omap@...r.kernel.org, linux-arm-msm@...r.kernel.org,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH v5 1/3] usb: dwc3: msm: Add device tree binding
 information

Hi, 

On Mon, 2013-09-23 at 16:03 -0600, Stephen Warren wrote: 
> On 09/23/2013 01:32 PM, Felipe Balbi wrote:
> > Hi,
> > 
> > On Wed, Aug 21, 2013 at 04:29:44PM +0300, Ivan T. Ivanov wrote:
> >> From: "Ivan T. Ivanov" <iivanov@...sol.com>
> >> 
> >> MSM USB3.0 core wrapper consist of USB3.0 IP from Synopsys (SNPS)
> >> and HS, SS PHY's control and configuration registers.
> >> 
> >> It could operate in device mode (SS, HS, FS) and host mode (SS,
> >> HS, FS, LS).
> >> 
> >> Signed-off-by: Ivan T. Ivanov <iivanov@...sol.com>
> > 
> > and here's a new version from same patch
> 
> The binding looks pretty simple, so I don't think it's too contentious.
> 
> >> diff --git a/Documentation/devicetree/bindings/usb/msm-ssusb.txt
> >> b/Documentation/devicetree/bindings/usb/msm-ssusb.txt
> 
> >> +MSM DWC3 controller wrapper
> 
> >> +Optional properties : +- gdsc-supply : phandle to the globally
> >> distributed switch controller +  regulator node to the USB
> >> controller.
> 
> If that's a regulator node, why not use xxx-supply properties to
> interface with it?

That was the intention. What about:

Optional "supply-name" :
    "gdsc" - supply from globally distributed switch controller


> 
> Aside from that, the binding,
> Acked-by: Stephen Warren <swarren@...dia.com>

Thank you.

Regards,
Ivan

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/